feat(item-sliding): added specific animations for ionic#31103
feat(item-sliding): added specific animations for ionic#31103os-davidlourenco wants to merge 10 commits intonextfrom
Conversation
os-davidlourenco
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
removed
package: angular
os-davidlourenco
force-pushed
the
ROU-12715
branch
from
6dc87ba to
a247ac5
Compare
os-davidlourenco
force-pushed
the
ROU-12715
branch
from
c2f1465 to
7468b4c
Compare
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Update the branch to be up to sync with next. We had to make changes to the item sliding tests that were causing tests that were failing while you were out. I would recommend reviewing the fix in case your tests need to be updated.
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Left a comment on the ticket!
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
I only reviewed the test. I'll leave the rest to the current reviewers.
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
The issues I found were addressed. Great work! 💪 I did leave a comment on the Jira ticket with my concerns on the pull threshold.
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
dragElementBy does support velocity control - its steps param (8th arg) is purpose-built for it: lower steps = higher velocity. We already use the inverse in this branch with DRAG_STEPS_UNDER_FULL_SWIPE = 15 to stay below the threshold; passing steps: 2 triggers full swipe.
The util also handles a WebKit quirk (drag-element.ts:163-171) where Safari needs RAF waits for velocity to accumulate. Raw page.mouse.* skips that — your version produced flaky results when re-run, while the dragElementBy refactor was stable across --repeat-each.
I highly encourage getting familiar with dragElementBy as that is the util that should be used when possible for our gesture tests.
I provided the code snippets to use dragElementBy instead while still having your intended results.
4 participants
Issue number: resolves internal
What is the current behavior?
The
item-slidinghas the same animations for md, iOS and IonicWhat is the new behavior?
New animations were added for the Ionic theme, including:
item-slidingitem-slidingNew conditions were also included to ensure a smoother experience:
item-slidingby exceeding velocityDoes this introduce a breaking change?
Other information